Upgrade vaadin and importmap and add caching #35712
Conversation
quarkus-bot
bot
added
area/dependencies
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
dev-ui-lib-updates
branch
from
8842df5 to
4d6c0cd
Compare
| } | ||
|
|
||
| private String formatDate(TemporalAccessor t) { | ||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("EEE, dd MMM yyyy HH:mm:ss z", Locale.ENGLISH) |
There was a problem hiding this comment.
Isn't that a bit expensive?
Isn't that the API that was made thread-safe?
@geoand do you know?
There was a problem hiding this comment.
Isn't that the API that was made thread-safe
Correct.
Isn't that a bit expensive?
Yeah, it's not very performant AFAIK. Netty has DateFormatter but I don't know how it compares and if it has been optimized. @franz1981 do you know?
There was a problem hiding this comment.
If it's an hot path probably worth using a whole different pattern...
The easier thing is to save in a static final field the formatter, which is immutable and thread safe (please check the doc yourself, I am still on PTO so I have limited GitHub access..).
The best would be to have a volatile field with the formatted string, updated using a timer (or some scheduled task) with second granularity. It's less costly and in the hot path the best solution overall.
There was a problem hiding this comment.
As usual, measure, not guess; check if the date formatting is a costly hot path and you have few options to reduce its overhead...
@geoand I didn't checked Netty yet: will do with my beloved desktop at hand 👍
There was a problem hiding this comment.
This is Dev mode only, and also Dev UI only, so for now I think we can merge.
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
phillip-kruger
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
This PR upgrade to the latest vaadin, that is now build with a new version of mvnpm, that allows caching of these resources.